This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Allow multiple instances of bitcore-lib with the same version - #4
Closed
pnagurny wants to merge 1 commit into
Closed
Allow multiple instances of bitcore-lib with the same version#4pnagurny wants to merge 1 commit into
pnagurny wants to merge 1 commit into
Conversation
pnagurny
force-pushed
the
feature/multiple-instances
branch
from
October 20, 2015 18:49
df94001 to
09fca53
Compare
Contributor
|
I think we still want to have a warning in the case that the original was used, as there could be changes outside the version number, especially during debugging. |
Contributor
|
If you allow multiple instances of one version you return original problem that was related with // in some library X
exports = function () {
return require('bitcore-lib').Transaction.Input(...)
}
// in code that use library X
require('bitcore-lib').Transaction().addInput(require('x')()) // throw InvalidArgumentType |
Closed
Contributor
|
Closing, too old / stalled. Please reopen if active. |
nitsujlangston
pushed a commit
to nitsujlangston/bitcore-lib
that referenced
this pull request
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.